[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: Add code for early tcss

[Julius Werner (Code Review)]

Attention is currently required from: Brandon Breitenstein.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42079 )

Change subject: soc/intel/tigerlake: Add code for early tcss
......................................................................

Patch Set 29:

(1 comment)

File src/soc/intel/tigerlake/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/42079/comment/067e5655_6877da02 
PS29, Line 391: 			vboot_developer_mode_enabled()))
Sorry, just found this randomly reading through how vboot_developer_mode_enabled() is used in coreboot... shouldn't this be using the display_init_required()/VBOOT_MUST_REQUEST_DISPLAY facility instead? This patch sounds like this code is required for using the display in firmware, but (rec_mode || dev_mode) is not the correct check for that. There are other situations (e.g. TCPC update) that use the display, that's why we have the display_init_required() facility to encapsulate that.