Attention is currently required from: Brandon Breitenstein.
1 comment:
File src/soc/intel/tigerlake/fsp_params.c:
Patch Set #29, Line 391: vboot_developer_mode_enabled()))
Sorry, just found this randomly reading through how vboot_developer_mode_enabled() is used in coreboot... shouldn't this be using the display_init_required()/VBOOT_MUST_REQUEST_DISPLAY facility instead? This patch sounds like this code is required for using the display in firmware, but (rec_mode || dev_mode) is not the correct check for that. There are other situations (e.g. TCPC update) that use the display, that's why we have the display_init_required() facility to encapsulate that.
To view, visit change 42079. To unsubscribe, or for help writing mail filters, visit settings.