Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47602 )
Change subject: [WIP] lib/version: Remove .id section and id.S files
......................................................................
Patch Set 6:
Well it turned out backwards flashrom compatibility needs null-terminated strings.
And FILO has assumptions for the vendor and part number strings to be next to each other.
So I cannot really touch the x86 part at all.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47602
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I35d3312336e9c66d657d2ca619cf30fd79e18fd4
Gerrit-Change-Number: 47602
Gerrit-PatchSet: 6
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 09 Dec 2020 05:27:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment