Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35012 )
Change subject: samsung/exynos,qualcomm/ipq: Avoid conflicting DRAM_START ......................................................................
Patch Set 2:
Patch Set 2:
Is this just because you include stddef.h from memlayout.h? I don't think we should do that, I think we should rather move those ARCH_STAGE_xxx definitions from memlayout.h into rules.h. memlayout.h was only ever meant to be the header included directly by memlayout.ld files and defining the memlayout "language", not a general collection of program state macros (that should be rules.h).
I think that would mean I have to include <arch/memlayout.h> in the middle of rules.h to make it work. Is that the preferred route to take?