build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48629 )
Change subject: add a command to write SR1 ......................................................................
Patch Set 2:
(6 comments)
https://review.coreboot.org/c/coreboot/+/48629/2/src/soc/intel/jasperlake/ro... File src/soc/intel/jasperlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/48629/2/src/soc/intel/jasperlake/ro... PS2, Line 150: for (i=0; i < 500; i++) { spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/48629/2/src/soc/intel/jasperlake/ro... PS2, Line 154: spi_flash_wr_status (spi, 0x00); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/48629/2/src/soc/intel/jasperlake/ro... PS2, Line 164: spi_flash_wr_status (spi, spi_sts1); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/48629/2/src/soc/intel/tigerlake/rom... File src/soc/intel/tigerlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/48629/2/src/soc/intel/tigerlake/rom... PS2, Line 151: for (i=0; i < 500; i++) { spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/48629/2/src/soc/intel/tigerlake/rom... PS2, Line 155: spi_flash_wr_status (spi, 0x00); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/48629/2/src/soc/intel/tigerlake/rom... PS2, Line 165: spi_flash_wr_status (spi, spi_sts1); space prohibited between function name and open parenthesis '('