Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31188 )
Change subject: mb/lenovo/t400: Remove RCBA replay ......................................................................
mb/lenovo/t400: Remove RCBA replay
his either sets unwanted or unnecessary settings.
Also this RCBA replay did not even originate from the T400 as this code was copied from the Thinkpad x200 code on which this replay was already removed in 7bcd062 'mb/lenovo/x200: Remove RCBA replay'
Change-Id: Iac6846d43395e342897e03c1ad31387638bcac64 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/31188 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/lenovo/t400/romstage.c 1 file changed, 0 insertions(+), 33 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/lenovo/t400/romstage.c b/src/mainboard/lenovo/t400/romstage.c index 1a708ae..5020c85 100644 --- a/src/mainboard/lenovo/t400/romstage.c +++ b/src/mainboard/lenovo/t400/romstage.c @@ -143,39 +143,6 @@ i82801ix_dmi_poll_vc1();
MCHBAR16(SSKPD_MCHBAR) = 0xCAFE; - /* Enable ethernet. */ - RCBA32(0x3414) &= ~0x20; - - RCBA32(0x0238) = 0x00543210; - RCBA32(0x0240) = 0x009c0b02; - RCBA32(0x0244) = 0x00a20b1a; - RCBA32(0x0248) = 0x005402cb; - RCBA32(0x0254) = 0x00470966; - RCBA32(0x0258) = 0x00470473; - RCBA32(0x0260) = 0x00e90825; - RCBA32(0x0278) = 0x00bc0efb; - RCBA32(0x027c) = 0x00c00f0b; - RCBA32(0x0280) = 0x00670000; - RCBA32(0x0284) = 0x006d0000; - RCBA32(0x0288) = 0x00600b4e; - RCBA32(0x1e10) = 0x00020800; - RCBA32(0x1e18) = 0x36ea00a0; - RCBA32(0x1e80) = 0x000c0801; - RCBA32(0x1e84) = 0x000200f0; - RCBA32(0x2028) = 0x04c8f95e; - RCBA32(0x202c) = 0x055c095e; - RCBA32(0x204c) = 0x001ffc00; - RCBA32(0x2050) = 0x00100fff; - RCBA32(0x2090) = 0x37000000; - RCBA32(0x20b0) = 0x0c000000; - RCBA32(0x20d0) = 0x09000000; - RCBA32(0x20f0) = 0x05000000; - RCBA32(0x3400) = 0x0000001c; - RCBA32(0x3410) = 0x00100461; - RCBA32(0x3414) = 0x00000000; - RCBA32(0x341c) = 0xbf4f001f; - RCBA32(0x3420) = 0x00000000; - RCBA32(0x3430) = 0x00000001;
init_iommu();