Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45705 )
Change subject: trogdor: Remove Limits config entry. ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45705/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45705/1//COMMIT_MSG@9 PS1, Line 9: Change-Id: Id913fc4a89ad5eff6b3487354ff8be7661539fe5 Also needs a Signed-off-by
https://review.coreboot.org/c/coreboot/+/45705/1/src/mainboard/google/trogdo... File src/mainboard/google/trogdor/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/45705/1/src/mainboard/google/trogdo... PS1, Line 12: RO_VPD(PRESERVE) 228K There'll be 4K of empty space in this section now (because there's no section without explicit size in this scope which would expand to fill the free space, like there is for the RW part). So please increase RO_VPD by 4K (to 232K) to make sure we don't waste that.
Or, maybe even better, just remove the `228K` from the RO_VPD line and then it will just fill all available space.