Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36864 )
Change subject: soc/intel/cannonlake: Add chip config to override CPU flex ratio ......................................................................
Patch Set 9:
Patch Set 9:
I would still like to have a detailed documentation of the UPD. It's still unclear to me how the system is affected after boot, as there is also `BootFrequency` which seems independent from this.
I guess you can refer to BWG chapter 11 title power management
Which BWG, document number please.
Its SKL CPU BWG (we have two BWG, one for CPU and another for PCH). doc 33391
Is this another document beside the "BIOS Specification"? I often confuse the two. Does your BWG only document the hardware or FSP too? Because in all the hardware documentation it says "Flex Ratio" and in FSP it says "CpuRatio". Please, where is it documented that that two mean the very same thing?
I guess its discrepancy in name which we can raise a request to fix, i will take a note. Its both same as you can read the help text from FSP-M header.
I trust you that the two are the same. But if it is not documented (e.g. in the FSP integration guide) then people will have these discussions over and over again, wasting a lot of time. And if you can do anything about it, please tell FSP teams to not invent new names. This is not the only occurence.
yes, got your point and its valid feedback.