Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38658 )
Change subject: mb/google/drallion/variants/drallion: Update thermal configuration for DPTF ......................................................................
Patch Set 2:
(2 comments)
I do not have bug access for this. Please, add me in this bug for more detailed analysis on this. Thanks.
https://review.coreboot.org/c/coreboot/+/38658/2/src/mainboard/google/dralli... File src/mainboard/google/drallion/variants/drallion/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/38658/2/src/mainboard/google/dralli... PS2, Line 34: 90 How did you arrive to such a high temperature thershold value for Ambient sensor for passive thermal throttling action ? Is it safe to put this high thershold ?
https://review.coreboot.org/c/coreboot/+/38658/2/src/mainboard/google/dralli... PS2, Line 60: 12 Did you check the performance impact due to reduction of this PL1 and PL2 values ? Kindly share any performance analysis results for these new values on bug as comment.