Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36888 )
Change subject: mb/compulab/intense_pc: Clean PCH and super-i/o config up ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/36888/1/src/mainboard/compulab/inte... File src/mainboard/compulab/intense_pc/early_init.c:
https://review.coreboot.org/c/coreboot/+/36888/1/src/mainboard/compulab/inte... PS1, Line 36: if (sio1007_enable_uart_at(SIO_PORT)) { : pci_write_config16(dev, LPC_EN, : lpc_config | COMA_LPC_EN); I thought it was here to avoid LPC decoding COMA if something went wrong with the superio. It's probably overscrupulous.