Werner Zeh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/55109 )
Change subject: mb/google/dedede/var/storo: Modify I2C times for touchpad ......................................................................
mb/google/dedede/var/storo: Modify I2C times for touchpad
Configure I2C rise/fall time in device tree to ensure I2C CLK runs accurately (380<frequency<400 kHz).
Measured touchpad I2C frequency is 394 kHz
BUG=b:189740533 BRANCH=dedede TEST=Build bios and make sure frequency meets specification.
Change-Id: Ibc0504a5be6fe9237b8b30783c659a761d10561a Signed-off-by: Zanxi Chen chenzanxi@huaqin.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/55109 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/mainboard/google/dedede/variants/storo/overridetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/mainboard/google/dedede/variants/storo/overridetree.cb b/src/mainboard/google/dedede/variants/storo/overridetree.cb index 40b17df..6336192 100644 --- a/src/mainboard/google/dedede/variants/storo/overridetree.cb +++ b/src/mainboard/google/dedede/variants/storo/overridetree.cb @@ -26,8 +26,8 @@ }, .i2c[0] = { .speed = I2C_SPEED_FAST, - .rise_time_ns = 125, - .fall_time_ns = 19, + .rise_time_ns = 260, + .fall_time_ns = 50, }, .i2c[1] = { .speed = I2C_SPEED_FAST,