Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31746 )
Change subject: lint/kconfig: Fix check for IS_ENABLED(XXX) where someone forgot CONFIG_
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/31746/1/util/lint/kconfig_lint
File util/lint/kconfig_lint:
https://review.coreboot.org/#/c/31746/1/util/lint/kconfig_lint@a239
PS1, Line 239:
Right... […]
IIRC, it's not covered by POSIX basic regexp. But that doesn't matter. Even
if somebody runs this with a grep that doesn't know <, it would just be a
false negative as before.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31746
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2296410c73cd6e918465c90db33e782936bec0f9
Gerrit-Change-Number: 31746
Gerrit-PatchSet: 3
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 05 Mar 2019 22:39:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment