Nico Huber has posted comments on this change. ( https://review.coreboot.org/28935 )
Change subject: nb/i945: Check if IGD is enabled before R/W to dev(0, 2) ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/28935/1/src/northbridge/intel/i945/raminit.c File src/northbridge/intel/i945/raminit.c:
https://review.coreboot.org/#/c/28935/1/src/northbridge/intel/i945/raminit.c... PS1, Line 2764: pci_read_config8(PCI_DEV(0, 0x0, 0), DEVEN) & : (DEVEN_D2F0 | DEVEN_D2F1)
what I'm trying to explain is : […]
And what I was trying to explain is: This code here runs *before* the code in i945_setup_pci_express_x16(). So the IGD can't be disabled yet.