Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38006 )
Change subject: usbdebug: Fix printk conversion
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38006/1/src/drivers/usb/ehci_debug....
File src/drivers/usb/ehci_debug.c:
https://review.coreboot.org/c/coreboot/+/38006/1/src/drivers/usb/ehci_debug....
PS1, Line 455: dprintk(BIOS_INFO, "ehci_bar: 0x%zx debug_offset 0x%x\n", ehci_bar, offset);
Uint pointers are not directly related with size_t. Would prefer `lx` instead […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38006
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0dba96004de264fe1faf5485fb677a6b05123bba
Gerrit-Change-Number: 38006
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 03 Jan 2020 10:21:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment