Attention is currently required from: Kane Chen, Kapil Porwal, Pratikkumar V Prajapati.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78257?usp=email )
Change subject: soc/intel/common: Refactor BERT generation flow for crashlog
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/common/block/acpi/acpi_bert.c:
https://review.coreboot.org/c/coreboot/+/78257/comment/3ab158a5_e193395c :
PS2, Line 29: cl_acpi_data
can u do a malloc here ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78257?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I43bb61485b77d786647900ca284b7f492f412aee
Gerrit-Change-Number: 78257
Gerrit-PatchSet: 2
Gerrit-Owner: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-CC: Pratikkumar Prajapati
pratikkumar.v.prajapati@intel.corp-partner.google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Kane Chen
kane.chen@intel.com
Gerrit-Attention: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Comment-Date: Fri, 06 Oct 2023 09:01:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment