Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35672 )
Change subject: device/pci_early: Drop some __SIMPLE_DEVICE__ use
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35672/1/src/device/pci_early.c
File src/device/pci_early.c:
https://review.coreboot.org/c/coreboot/+/35672/1/src/device/pci_early.c@a36
PS1, Line 36: pci_write_config16(p2p_bridge, PCI_BRIDGE_CONTROL, reg16);
ad retry loop: I'm not sure if device 0 is always required to be on secondary side I think I've seen […]
Conventional PCI might not have device 0 on secondary. I think PCIe bridges have device 0 compulsory, and only PCIe switches may have devices other than 0 on secondary.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35672
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia97a4e1f1b4c80b3dae800d80615bdc118414ed3
Gerrit-Change-Number: 35672
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Petr Cvek
petrcvekcz@gmail.com
Gerrit-Comment-Date: Mon, 30 Sep 2019 09:11:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Petr Cvek
petrcvekcz@gmail.com
Gerrit-MessageType: comment