Name of user not set #1002476 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35310 )
Change subject: emulation/qemu-i440fx/fw_cfg_if.h: replace macro with enum ......................................................................
Patch Set 2:
Patch Set 2:
Since this is a copy of the QEMU file, do we really want to change away from matching the original? It'll make it harder to diff changes in the future.
I have already been through the original qemu source tree, git diff with "include/hw/nvram/fw_cfg.h" is not as expected now, owing to much changes compared at the time of copying over the same into the coreboot. I think we should modify the comment accordingly as the file path should be "include/standard-headers/linux/qemu_fw_cfg.h" and mention the modification according to the coreboot.