Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44782 )
Change subject: fw_config: Add caching to successfully probed fields
......................................................................
Patch Set 1:
is this problem much different from specifying the underlying
USB port numbers in the conn driver? can we add support for
a "i2s-port" field to the appropriate coreboot driver for the
kernel driver to pick up? we might need to add a skeletal
alc5682i.c driver if the max98*.c driver isn't the right place.
actually, soundwire alc5682/max98373 use the generic x.y
path specifier, so maybe that's another option to specify
the i2s port number needed to pass to the kernel.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44782
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d014206a4ee6cc7592e12e704a7708652330eaf
Gerrit-Change-Number: 44782
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Caveh Jalali
caveh@chromium.org
Gerrit-Comment-Date: Tue, 25 Aug 2020 20:58:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment