Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48228 )
Change subject: vc/intel/fsp/fsp2_0/cooperlake_sp: Update WW47 FSP Memory map HOB
......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2: Code-Review+2
We will get Intel to do a major cleanup for HOB header file composition in SPR-SP FSP...
Did the version checks go in? This should be updated with a FSP version update.
No. Intel (Nate) advised us not to do version check based on build number which contains WW. So Intel has to revisit their verisoning method for CPX-SP FSP, then we can do corresponding coreboot work.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48228
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7bb2e9f41daa4cbce49169535eadf7f0d4972716
Gerrit-Change-Number: 48228
Gerrit-PatchSet: 2
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 02 Dec 2020 18:06:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment