build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33552 )
Change subject: mb/google/octopus: Override DDI1 DDC SDA/SCL for Garg HDMI ......................................................................
Patch Set 3:
(7 comments)
https://review.coreboot.org/#/c/33552/3/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/garg/gpio.c:
https://review.coreboot.org/#/c/33552/3/src/mainboard/google/octopus/variant... PS3, Line 23: SKU_1_2A2C = 1, code indent should use tabs where possible
https://review.coreboot.org/#/c/33552/3/src/mainboard/google/octopus/variant... PS3, Line 23: SKU_1_2A2C = 1, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33552/3/src/mainboard/google/octopus/variant... PS3, Line 24: SKU_9_HDMI = 9, code indent should use tabs where possible
https://review.coreboot.org/#/c/33552/3/src/mainboard/google/octopus/variant... PS3, Line 24: SKU_9_HDMI = 9, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33552/3/src/mainboard/google/octopus/variant... PS3, Line 25: SKU_17_LTE = 17, code indent should use tabs where possible
https://review.coreboot.org/#/c/33552/3/src/mainboard/google/octopus/variant... PS3, Line 25: SKU_17_LTE = 17, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33552/3/src/mainboard/google/octopus/variant... PS3, Line 60: switch(sku_id) { space required before the open parenthesis '('