Attention is currently required from: Angel Pons, Shelly Chang.
Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69147 )
Change subject: drivers/ocp/ewl: Add sending Meta's BMC SEL for memory training error
......................................................................
Patch Set 3:
(2 comments)
File src/drivers/ipmi/ocp/ipmi_ocp.h:
https://review.coreboot.org/c/coreboot/+/69147/comment/a292c061_5813b950
PS2, Line 195: #define INTEL_MEMORY_ERROR 0x21
nit: place this so that the macro numbers are in ascending order?
Done
File src/drivers/ocp/ewl/ewl.c:
https://review.coreboot.org/c/coreboot/+/69147/comment/c13e213d_0bb7a16b
PS2, Line 12: = 0xff
Unused assignment
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69147
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I664e9d3da7910b47260881c0df64159c8dbe2dca
Gerrit-Change-Number: 69147
Gerrit-PatchSet: 3
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Shelly Chang
Shelly_Chang@wiwynn.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Shelly Chang
Shelly_Chang@wiwynn.com
Gerrit-Comment-Date: Thu, 03 Nov 2022 11:09:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment