Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43442 )
Change subject: mb/google/volteer: Add new variant Lingcod
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/43442/2/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/lingcod/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/43442/2/src/mainboard/google/voltee...
PS2, Line 8: /* Copied from baseboard and may need to change for the new variant. */
Any changes needed?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43442
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f79431d3948788ce27ae14b469ffc229ebf8b6a
Gerrit-Change-Number: 43442
Gerrit-PatchSet: 2
Gerrit-Owner: Tommie Lin
tong.lin@bitland.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 14 Jul 2020 07:56:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment