Jorge Fernandez has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37532 )
Change subject: [NOT FOR MERGE] northbridge: Don't use both _ADR and _HID ......................................................................
Patch Set 3:
Patch Set 2:
I was pointed to start my bettong port in an old commit from Apr (f77f2c79c2bb898c123ffe89a0bd1acb5362afc5) because now the board is disabled.
Oh, I see now. Sorry for my confusion. What I would do, in a a case like that, is to change the commit message here to reflect that it won't be merged onto master. That way anyone reviewing can see what you're doing and understand the reasons. I would probably write the commit message something like:
[NOT FOR MERGE] northbridge: Don't use both _ADR and _HID
This patch duplicates removal of _HID as in CB:37532 and allows older source to build and boot on Bettong.
Good thought. But I hesitate because I'm doing all this commits to be merged because to push a board_status report it seems all commits should be merged, if I got it right. Or maybe if the commits are in Gerrit they can be used to build the same coreboot.rom as myself and the board_status report I report is valid if they come from known commit in Gerrit...