Patch Set 2:

I was pointed to start my bettong port in an old commit from Apr (f77f2c79c2bb898c123ffe89a0bd1acb5362afc5) because now the board is disabled.

Oh, I see now. Sorry for my confusion. What I would do, in a a case like that, is to change the commit message here to reflect that it won't be merged onto master. That way anyone reviewing can see what you're doing and understand the reasons. I would probably write the commit message something like:

[NOT FOR MERGE] northbridge: Don't use both _ADR and _HID

This patch duplicates removal of _HID as in CB:37532 and allows
older source to build and boot on Bettong.

Good thought. But I hesitate because I'm doing all this commits to be merged because to push a board_status report it seems all commits should be merged, if I got it right. Or maybe if the commits are in Gerrit they can be used to build the same coreboot.rom as myself and the board_status report I report is valid if they come from known commit in Gerrit...

View Change

To view, visit change 37532. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I48fb3e9e48893336416eb90f80957e5bd21d1711
Gerrit-Change-Number: 37532
Gerrit-PatchSet: 3
Gerrit-Owner: Jorge Fernandez
Gerrit-Reviewer: Jorge Fernandez
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Frans Hendriks <fhendriks@eltan.com>
Gerrit-CC: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Tue, 10 Dec 2019 17:42:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment