Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39805 )
Change subject: acpi: Bump FADT to revision 6 ......................................................................
Patch Set 5: Code-Review+2
(14 comments)
Patch Set 5:
Dropped from common defintions.
ack.
Verified booting Win 10 on IVB, HSW, BDW, BSW, SKL, KBL
https://review.coreboot.org/c/coreboot/+/39805/4/src/mainboard/emulation/qem... File src/mainboard/emulation/qemu-q35/acpi_tables.c:
https://review.coreboot.org/c/coreboot/+/39805/4/src/mainboard/emulation/qem... PS4, Line 42: acpi_create_fadt
missing: […]
Done
https://review.coreboot.org/c/coreboot/+/39805/4/src/mainboard/lenovo/t400/f... File src/mainboard/lenovo/t400/fadt.c:
https://review.coreboot.org/c/coreboot/+/39805/4/src/mainboard/lenovo/t400/f... PS4, Line 22: acpi_create_fadt
missing: […]
Done
https://review.coreboot.org/c/coreboot/+/39805/4/src/mainboard/lenovo/x200/f... File src/mainboard/lenovo/x200/fadt.c:
https://review.coreboot.org/c/coreboot/+/39805/4/src/mainboard/lenovo/x200/f... PS4, Line 22: acpi_create_fadt
missing: […]
Done
https://review.coreboot.org/c/coreboot/+/39805/4/src/mainboard/roda/rk9/fadt... File src/mainboard/roda/rk9/fadt.c:
https://review.coreboot.org/c/coreboot/+/39805/4/src/mainboard/roda/rk9/fadt... PS4, Line 22: acpi_create_fadt
missing: […]
Done
https://review.coreboot.org/c/coreboot/+/39805/4/src/soc/amd/picasso/acpi.c File src/soc/amd/picasso/acpi.c:
https://review.coreboot.org/c/coreboot/+/39805/4/src/soc/amd/picasso/acpi.c@... PS4, Line 70: acpi_create_fadt
missing: […]
Done
https://review.coreboot.org/c/coreboot/+/39805/4/src/soc/amd/stoneyridge/acp... File src/soc/amd/stoneyridge/acpi.c:
https://review.coreboot.org/c/coreboot/+/39805/4/src/soc/amd/stoneyridge/acp... PS4, Line 72: acpi_create_fadt
missing: […]
Done
https://review.coreboot.org/c/coreboot/+/39805/4/src/soc/intel/baytrail/acpi... File src/soc/intel/baytrail/acpi.c:
https://review.coreboot.org/c/coreboot/+/39805/4/src/soc/intel/baytrail/acpi... PS4, Line 138: acpi_fill_in_fadt
missing: […]
Done
https://review.coreboot.org/c/coreboot/+/39805/4/src/soc/intel/braswell/acpi... File src/soc/intel/braswell/acpi.c:
https://review.coreboot.org/c/coreboot/+/39805/4/src/soc/intel/braswell/acpi... PS4, Line 142: acpi_fill_in_fadt
missing: […]
Done
https://review.coreboot.org/c/coreboot/+/39805/3/src/soc/intel/broadwell/acp... File src/soc/intel/broadwell/acpi.c:
https://review.coreboot.org/c/coreboot/+/39805/3/src/soc/intel/broadwell/acp... PS3, Line 300:
extra line?
Done
https://review.coreboot.org/c/coreboot/+/39805/4/src/soc/intel/broadwell/acp... File src/soc/intel/broadwell/acpi.c:
https://review.coreboot.org/c/coreboot/+/39805/4/src/soc/intel/broadwell/acp... PS4, Line 193: acpi_fill_in_fadt
missing: […]
Done
https://review.coreboot.org/c/coreboot/+/39805/4/src/soc/intel/quark/acpi.c File src/soc/intel/quark/acpi.c:
https://review.coreboot.org/c/coreboot/+/39805/4/src/soc/intel/quark/acpi.c@... PS4, Line 31: acpi_fill_in_fadt
missing: […]
Done
https://review.coreboot.org/c/coreboot/+/39805/4/src/southbridge/intel/i8237... File src/southbridge/intel/i82371eb/fadt.c:
https://review.coreboot.org/c/coreboot/+/39805/4/src/southbridge/intel/i8237... PS4, Line 30: acpi_create_fadt
missing: […]
Done
https://review.coreboot.org/c/coreboot/+/39805/3/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/lpc.c:
https://review.coreboot.org/c/coreboot/+/39805/3/src/southbridge/intel/lynxp... PS3, Line 883: ACPI_ACCESS_SIZE_BYTE_ACCESS
this needs to be DWORD, like Broadwell
Done
https://review.coreboot.org/c/coreboot/+/39805/3/src/southbridge/intel/lynxp... PS3, Line 884: pmbase + GPE0_STS
this should be same value as fadt->gpe0_blk, which is `pmbase + LP_GPE0_STS_1` for LP. […]
Done