Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35246 )
Change subject: mb/emulation/qemu-riscv: Implement ipi using clint to enable smp in qemu/spike.
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/35246/3/src/mainboard/emulation/spi...
File src/mainboard/emulation/spike-riscv/clint.c:
https://review.coreboot.org/c/coreboot/+/35246/3/src/mainboard/emulation/spi...
PS3, Line 31: write32((void *)(SPIKE_CLINT_BASE + 4 * (uintptr_t)hartid), !!val);
the uintptr_t confused me, is it necessary?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35246
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I94fb25fad103e3cb5db676eb4caead11d54ae0ae
Gerrit-Change-Number: 35246
Gerrit-PatchSet: 3
Gerrit-Owner: Philipp Hug
philipp@hug.cx
Gerrit-Assignee: Patrick Rudolph
patrick.rudolph.100@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph.100@gmail.com
Gerrit-Comment-Date: Tue, 10 Sep 2019 17:54:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment