Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41280 )
Change subject: security/tpm/tspi/crtm.c: Fix handling of white space delimited list
......................................................................
Patch Set 6:
Patch Set 6: Code-Review+1
(1 comment)
The implementation looks good. But it's hard to assess the impact of
changing the string format (from comma to whitespace). IMHO, this
should be a separate patch, people should be notified and maybe
the Kconfig name should also change so it becomes visible in `make
oldconfig`.
I had the same thought, but then settled on the assumption, that the current behavior is broken and never worked despite for having one word. Or am I missing something?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41280
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd285162ea6e562a5bb18325a1b767ac2e4276f3
Gerrit-Change-Number: 41280
Gerrit-PatchSet: 6
Gerrit-Owner: Harshit Sharma
harshitsharmajs@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Fri, 15 May 2020 14:17:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment