Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mediatek/mt8183: add a new panel configuration for Kodama ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34505/2/src/mainboard/google/kukui/... File src/mainboard/google/kukui/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/34505/2/src/mainboard/google/kukui/... PS2, Line 25: ramstage-y += display.c : ramstage-$(CONFIG_BOARD_GOOGLE_KUKUI) += panel_kukui.c : ramstage-$(CONFIG_BOARD_GOOGLE_KRANE) += panel_krane.c these should not exist in your commit.
https://review.coreboot.org/c/coreboot/+/34505/2/src/mainboard/google/kukui/... PS2, Line 28: panel_kodama can we just reuse panel_krane.c ?
https://review.coreboot.org/c/coreboot/+/34505/2/src/mainboard/google/kukui/... File src/mainboard/google/kukui/display.h:
https://review.coreboot.org/c/coreboot/+/34505/2/src/mainboard/google/kukui/... PS2, Line 2: This this file should be removed
https://review.coreboot.org/c/coreboot/+/34505/2/src/mainboard/google/kukui/... File src/mainboard/google/kukui/panel_kodama.c:
https://review.coreboot.org/c/coreboot/+/34505/2/src/mainboard/google/kukui/... PS2, Line 35: PANEL_KODAMA_BOE_TV101WUM_NL6 Is this the same as TV101WUM N16? If yes, we should just share krane_panel.c (be aware the EDID and LCM init seq below are different).
If not, please sync with HW eng (ayo/alvis) to see if you should choose a new LCM ID that does not conflict.