Attention is currently required from: Marshall Dawson, Martin L Roth, Varshit Pandya.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79528?usp=email )
Change subject: [UNTESTED] soc/amd/genoa_poc: add CPPC support
......................................................................
Patch Set 9:
(1 comment)
Patchset:
PS9:
hmm, the cppc package matches between the uefi reference firmware and coreboot+opensil with this patch applied except for the last two values.
expected is 0x00000190, 0x00000867, but we get 0x00000867, 0x00000000 which smells like an off by one in the smu mailbox command IDs to me
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79528?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icc40a92810e845dc8eeba3908f5bfce274df2ab9
Gerrit-Change-Number: 79528
Gerrit-PatchSet: 9
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Comment-Date: Fri, 12 Jan 2024 15:18:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment