Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30800 )
Change subject: southbridge/intel/common/smbus.c: Add support for i2c block write
......................................................................
Patch Set 17: Code-Review-1
(1 comment)
Sorry, I don't understand this. Is the datasheet of the
tested I2C slave public? AFAICT, the current code would
issue an SMBUS (not I2C) transaction.
https://review.coreboot.org/#/c/30800/17/src/southbridge/intel/common/smbus....
File src/southbridge/intel/common/smbus.c:
https://review.coreboot.org/#/c/30800/17/src/southbridge/intel/common/smbus....
PS17, Line 424: I801_BLOCK_DATA
This is not the I2C command. I wonder now what is the difference
here to do_smbus_block_write()?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30800
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I40f8c0f5257a62398189f36892b8159052481693
Gerrit-Change-Number: 30800
Gerrit-PatchSet: 17
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 05 Jun 2019 13:42:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
