HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31267 )
Change subject: mb/{asrock,intel,kontron}: Include missing <arch/io.h> ......................................................................
Patch Set 2:
(1 comment)
can you check if a timeless build produces the same binary with
the
patch applied? I'm not 100% sure if changing the order of the includes will
change
things; since the code quality of x4x and sandybridge is rather good, I don't really expect breakage from this though
sure, I will
Test with "make BUILD_TIMELESS=1" done on kontron/ktqm77 and asus/p5qpl-am. got the same md5sum build/coreboot.rom.
13d588fefd474a5e0ca3ce5439ea5edf for ktqm77 and 986cb89f71e1667b723d045c98d10b4c for p5qpl-am