Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36824 )
Change subject: mb/amd/padmelon: Use Prairie Falcon configuration ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36824/2/src/mainboard/amd/padmelon/... File src/mainboard/amd/padmelon/Kconfig:
https://review.coreboot.org/c/coreboot/+/36824/2/src/mainboard/amd/padmelon/... PS2, Line 18: choice PADMELON_SOC This whole change should move below BOARD_SPECIFIC_OPTIONS. My recommendation would be after the part number.
https://review.coreboot.org/c/coreboot/+/36824/2/src/mainboard/amd/padmelon/... PS2, Line 30: if PADMELON_MERLIN_FALCON : config SOC_AMD_MERLINFALCON : bool : default y : help : AMD Merlin Falcon FP4 support : endif : : if PADMELON_PRAIRIE_FALCON : config SOC_AMD_PRAIRIEFALCON : bool : default y : help : AMD Prairie Falcon FP4 support : endif I believe this should work instead.
config PADMELON_SOC bool select SOC_AMD_MERLINFALCON if PADMELON_MERLIN_FALCON select SOC_AMD_PRAIRIEFALCON if PADMELON_PRAIRIE_FALCON