Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41885 )
Change subject: dptf: Add support for generation of Active Policies
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41885/7/src/acpi/acpigen_dptf.c
File src/acpi/acpigen_dptf.c:
https://review.coreboot.org/c/coreboot/+/41885/7/src/acpi/acpigen_dptf.c@39
PS7, Line 39: TFN1
could these be more descriptive (like DPTF_CHARGER) since the ACPI name is hidden?
https://review.coreboot.org/c/coreboot/+/41885/7/src/acpi/acpigen_dptf.c@75
PS7, Line 75: Almost all Intel boards use a Global NVS field named DPTE.
Should we kill this? can just turn off the device in the devicetree to prevent the ACPI from being generated.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41885
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iea0ccbd96f88d0f3a8f2c77a7d0f3a284e5ee463
Gerrit-Change-Number: 41885
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 04 Jun 2020 20:28:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment