Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43087 )
Change subject: mb/bostentech: Add GBYT4 port ......................................................................
Patch Set 18:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43087/18/src/mainboard/bostentech/g... File src/mainboard/bostentech/gbyt4/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43087/18/src/mainboard/bostentech/g... PS18, Line 78: io 0x60 = 0x0a30 just wondering: does accessing these ranges work? I'm not so familiar with how baytrail sets up LPC IO decode ranges.
https://review.coreboot.org/c/coreboot/+/43087/18/src/mainboard/bostentech/g... File src/mainboard/bostentech/gbyt4/mainboard.c:
https://review.coreboot.org/c/coreboot/+/43087/18/src/mainboard/bostentech/g... PS18, Line 123: #if CONFIG(VGA_ROM_RUN) if you use regular C code instead of preprocessor, it will still get build-tested even if CONFIG_VGA_ROM_RUN is not set even though the linker will optimize things so it does not end up in the final binary.