[coreboot-gerrit] [M] Change in coreboot[main]: util/crossgcc: Add libstdcxx target

[Raul Rangel (Code Review)]

Attention is currently required from: Felix Singer, Jon Murphy, Karthik Ramasubramanian, Martin L Roth.

Raul Rangel has posted comments on this change by Jon Murphy. ( https://review.coreboot.org/c/coreboot/+/85275?usp=email )

Change subject: util/crossgcc: Add libstdcxx target
......................................................................

Patch Set 11:

(3 comments)

File util/crossgcc/buildgcc:

https://review.coreboot.org/c/coreboot/+/85275/comment/dc16fca8_c0f11831?usp... :
PS11, Line 841: ${EXTRA_ARGS}
Can we drop the EXTRA_ARGS and just pass `$@` here?

https://review.coreboot.org/c/coreboot/+/85275/comment/f69b6ada_6cf510df?usp... :
PS11, Line 845: set -- ""
              : 	EXTRA_ARGS="$@"
Doesn't this set `EXTRA_ARGS=""`?

https://review.coreboot.org/c/coreboot/+/85275/comment/86ba139c_7b2c6d16?usp... :
PS11, Line 867: 	set -- "--with-gxx-include-dir="${LIBSTDCXX_INCLUDE_PATH}/coreboot-${TARGETARCH}/include/"
              : 			--with-sysroot="${LIBSTDCXX_INCLUDE_PATH}/""
              : 	EXTRA_ARGS="$@"
              : 	configure_GCC "${EXTRA_ARGS}"
```suggestion
    configure_GCC --with-gxx-include dir="${LIBSTDCXX_INCLUDE_PATH}/coreboot-${TARGETARCH}/include/" \
    	--with-sysroot="${LIBSTDCXX_INCLUDE_PATH}/"
```