Attention is currently required from: Furquan Shaikh, Rob Barnes.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52143 )
Change subject: mb/google/guybrush: Unmask eSPI keyboard IRQ
......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS3:
+1. We already have vw_irq_polarity. […]
Ack
File src/mainboard/google/guybrush/mainboard.c:
https://review.coreboot.org/c/coreboot/+/52143/comment/8d03b424_311d5cc9
PS3, Line 119: pm_write32(PM_ESPI_INTR_CTRL, PM_ESPI_DEV_INTR_MASK & ~(BIT(1)));
I think this should be done as part of `espi_configure()`. […]
Files b/184678786 so we can work out the API change. Also added a TODO to the code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52143
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I97b7382eac28aae2cc82f430c58cf8066b9701e1
Gerrit-Change-Number: 52143
Gerrit-PatchSet: 4
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Comment-Date: Tue, 06 Apr 2021 22:45:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment