Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38846 )
Change subject: soc/intel/cannonlake: Plumb TetonGlacierMode into dt ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38846/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/38846/1/src/mainboard/google/hatch/... PS1, Line 6: TetonGlacierMode This doesn't exist in chip config.
https://review.coreboot.org/c/coreboot/+/38846/1/src/mainboard/google/hatch/... PS1, Line 7: I believe you also need to set PcieRpEnable for RP11.