Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34075 )
Change subject: arch, include, soc: Use common stdint.h
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34075/6/src/include/stdint.h
File src/include/stdint.h:
https://review.coreboot.org/c/coreboot/+/34075/6/src/include/stdint.h@105
PS6, Line 105: ifdef
Absolutely minor and negligible, no need to change anything at all, BUT I *have to* point it out any […]
FWIW I think #ifdef is always preferable to #ifndef if there's an #else branch (it's just easier to follow). The other ones use #ifndef because there is no #else.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34075
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6b52f37793151041b7bdee9ec3708bfad69617b2
Gerrit-Change-Number: 34075
Gerrit-PatchSet: 6
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 11 Jul 2019 17:42:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment