Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47026 )
Change subject: soc/intel/broadwell/pch/sata.c: Don't enable Bus Master
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47026/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47026/2//COMMIT_MSG@9
PS2, Line 9: Bus Master is not required and reference code does not set it.
Did you test it and does it still work?
Not yet, but there's a hundred commits before this one. There's plenty of time to test 😄
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47026
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2f70486f96cf3dcaba74283293b93b9747cd0300
Gerrit-Change-Number: 47026
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 30 Oct 2020 18:00:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Gerrit-MessageType: comment