22 Apr
2021
22 Apr
'21
8:50 p.m.
Attention is currently required from: Tim Crawford, Jeremy Soller. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52396 )
Change subject: mb/system76/oryp5: Leave NC GPIOs unterminated ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/mainboard/system76/oryp5/gpio.c:
https://review.coreboot.org/c/coreboot/+/52396/comment/55d27b95_aa7ea24e PS1, Line 253: PAD_CFG_TERM_GPO(GPP_K14, 0, UP_20K, DEEP),
Hm?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/52396
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia85ea39d46d7d9584b94726a7d601ca06826b1d1
Gerrit-Change-Number: 52396
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Crawford tcrawford@system76.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Jeremy Soller jeremy@system76.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Tim Crawford tcrawford@system76.com
Gerrit-Attention: Jeremy Soller jeremy@system76.com
Gerrit-Comment-Date: Thu, 22 Apr 2021 10:50:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment