Ajit Pandey has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38593 )
Change subject: sc7180: GPIO: Add I2S configuration for sc7180 ......................................................................
Patch Set 22:
(8 comments)
https://review.coreboot.org/c/coreboot/+/38593/21//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38593/21//COMMIT_MSG@7 PS21, Line 7: for sc7180
Already in the prefix, but the prefix should be: […]
done
https://review.coreboot.org/c/coreboot/+/38593/21//COMMIT_MSG@8 PS21, Line 8:
Please add a problem description. Something like: […]
done
https://review.coreboot.org/c/coreboot/+/38593/21//COMMIT_MSG@9 PS21, Line 9: Audio
audio
done
https://review.coreboot.org/c/coreboot/+/38593/21//COMMIT_MSG@9 PS21, Line 9: Configuring GPIO Pins as I2S mode for Audio speaker.
… as per schematics?
done
https://review.coreboot.org/c/coreboot/+/38593/21//COMMIT_MSG@9 PS21, Line 9: Configuring
Configure
done
https://review.coreboot.org/c/coreboot/+/38593/21//COMMIT_MSG@9 PS21, Line 9: Pins
pins
Done
https://review.coreboot.org/c/coreboot/+/38593/21//COMMIT_MSG@10 PS21, Line 10:
Is there a bug for this issue. Please add it as reference.
done
https://review.coreboot.org/c/coreboot/+/38593/16/src/mainboard/google/trogd... File src/mainboard/google/trogdor/mainboard.c:
https://review.coreboot.org/c/coreboot/+/38593/16/src/mainboard/google/trogd... PS16, Line 37: GPIO_PULL_UP
Hmm.. […]
done