Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34337 )
Change subject: soc/intel/common: add PAD_CFG_NF_BUF_TRIG macro ......................................................................
Patch Set 4:
(5 comments)
https://review.coreboot.org/c/coreboot/+/34337/2/src/soc/intel/common/block/... File src/soc/intel/common/block/gpio/Kconfig:
https://review.coreboot.org/c/coreboot/+/34337/2/src/soc/intel/common/block/... PS2, Line 49: SOC_INTEL_COMMON_BLOCK_GPIO_ADVANCED_MACROS
Ok. I will fix this in a new patch.
Ack
https://review.coreboot.org/c/coreboot/+/34337/2/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/gpio_defs.h:
https://review.coreboot.org/c/coreboot/+/34337/2/src/soc/intel/common/block/... PS2, Line 421: trig
I think it makes sense to have a macro for this case.
Ack
https://review.coreboot.org/c/coreboot/+/34337/2/src/soc/intel/common/block/... PS2, Line 427: trig
In my opinion, we should just update PAD_CFG_GPO to set trig to DISABLE. […]
Done in https://review.coreboot.org/c/coreboot/+/34406
https://review.coreboot.org/c/coreboot/+/34337/2/src/soc/intel/common/block/... PS2, Line 427: pull
That is definitely weird. Not sure what the use that really achieves.
Ok, I'll take this into account in the pads config for my motherboard Thanks
https://review.coreboot.org/c/coreboot/+/34337/1/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/gpio_defs.h:
https://review.coreboot.org/c/coreboot/+/34337/1/src/soc/intel/common/block/... PS1, Line 417: #define PAD_CFG0_BUF_BOTH_DIS PAD_CFG0_TX_DISABLE | PAD_CFG0_RX_DISABLE
Macros with complex values should be enclosed in parentheses
Ack