Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43303 )
Change subject: soc/amd/common: Use SPI settings from EFS
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43303/4/src/soc/amd/common/block/sp...
File src/soc/amd/common/block/spi/fch_spi.c:
https://review.coreboot.org/c/coreboot/+/43303/4/src/soc/amd/common/block/sp...
PS4, Line 92: *spi_speed, *spi_speed);
I might not agree about using same max spi_speed for all fast,norm,alt and tpm here. […]
using the same value for all four is very likely wrong as the EFS only contains information on the SPI flash frequency and mode, but not about the other (e)SPI frequencies
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43303
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I765dada14700f4800263d2d3844af07fad0e5b71
Gerrit-Change-Number: 43303
Gerrit-PatchSet: 4
Gerrit-Owner: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin Frodsham
justin.frodsham@amd.corp-partner.google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Mon, 20 Jul 2020 14:09:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment