Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37594 )
Change subject: libpayload/drivers/i8042: Add AT translated Keyboard support
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37594/1/payloads/libpayload/drivers...
File payloads/libpayload/drivers/i8042/keyboard.c:
https://review.coreboot.org/c/coreboot/+/37594/1/payloads/libpayload/drivers...
PS1, Line 332: if (CONFIG(LP_PC_KEYBOARD_AT_TRANSLATED)) {
Acturally we enable this before enter OS again. I think kernel doesn't detect this. […]
Sorry, I do not understand your answer. Could you please rephrase it?
I mean, the Linux kernel is able to initialize the device on all Chromebook devices, isn’t it?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37594
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie1053e24e44c5bad28b56cc92d091e24f3d9b6fd
Gerrit-Change-Number: 37594
Gerrit-PatchSet: 2
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 09 Dec 2019 12:54:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment