Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39702 )
Change subject: mb/pcengines/apu2/mptable.c: add GNB IOAPIC to MP Table
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/39702/1/src/mainboard/pcengines/apu...
File src/mainboard/pcengines/apu2/mptable.c:
https://review.coreboot.org/c/coreboot/+/39702/1/src/mainboard/pcengines/apu...
PS1, Line 54: ioapic_id = (io_apic_read((void *)IO_APIC2_ADDR, 0x00) >> 24);
nit: if you add an extra space before the equals sign, the two lines get aligned
I think, that is good for macros but not for normal assignments.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39702
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I385339761b3e1b5dcadb67b8ca29b1518c2db408
Gerrit-Change-Number: 39702
Gerrit-PatchSet: 1
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 23 Mar 2020 19:14:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment