[coreboot-gerrit] Change in ...coreboot[master]: RFC: riscv: Add initial support for 32bit boards

[ron minnich (Code Review)]

ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31253 )

Change subject: RFC: riscv: Add initial support for 32bit boards
......................................................................

Patch Set 2: Code-Review+1

(1 comment)

This is just what we wanted. Please see my one not very important comment.

https://review.coreboot.org/#/c/31253/1/src/lib/libgcc.c 
File src/lib/libgcc.c:

https://review.coreboot.org/#/c/31253/1/src/lib/libgcc.c@23 
PS1, Line 23: #if !IS_ENABLED(CONFIG_ARCH_X86) && !IS_ENABLED(CONFIG_ARCH_RISCV_RV32) /* work around lack of --gc-sections on x86 */
> line over 80 characters

ignore the buildbot, this is fine.
But the comment ought to be fixed, it's confusing to see rv32 there and an x85 comment. Maybe just change it to 
For architectures without --gc-sections.