[coreboot-gerrit] Change in coreboot[master]: mb/google/dedede: Add memory initialization support for dedede

[Aamir Bohra (Code Review)]

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39136 )

Change subject: mb/google/dedede: Add memory initialization support for dedede
......................................................................

Patch Set 18: Code-Review+2

(2 comments)

https://review.coreboot.org/c/coreboot/+/39136/17/src/mainboard/google/deded... 
File src/mainboard/google/dedede/romstage.c:

https://review.coreboot.org/c/coreboot/+/39136/17/src/mainboard/google/deded... 
PS17, Line 29:
> nit: can we remove the extra line.

Done

https://review.coreboot.org/c/coreboot/+/39136/17/src/mainboard/google/deded... 
File src/mainboard/google/dedede/variants/baseboard/include/baseboard/gpio.h:

https://review.coreboot.org/c/coreboot/+/39136/17/src/mainboard/google/deded... 
PS17, Line 20: 
             : /* Memory configuration board straps */
             : #define GPIO_MEM_CONFIG_0	GPP_C0
             : #define GPIO_MEM_CONFIG_1	GPP_C3
             : #define GPIO_MEM_CONFIG_2	GPP_C4
             : #define GPIO_MEM_CONFIG_3	GPP_C5
> can you please add below entry in gpio.c(early gpio table) […]

Done