Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48613 )
Change subject: nb/intel/sandybridge: Refactor ODT stretch table code
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/48613/2/src/northbridge/intel/sandy...
File src/northbridge/intel/sandybridge/raminit.c:
https://review.coreboot.org/c/coreboot/+/48613/2/src/northbridge/intel/sandy...
PS2, Line 240: NUM_SLOTS
out of scope for this patch, but the NUM_SLOTS define in the header file could really use a comment that that is per channel and not per socket/system; found that a bit confusing and had to look that up
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48613
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4e08166c8e9fbd15ff1dcd266abb0689e4b159f7
Gerrit-Change-Number: 48613
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 23 Dec 2020 16:22:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment