Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38716 )
Change subject: mb/google/octopus: Override VBT selection for Bipship
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38716/2/src/mainboard/google/octopu...
File src/mainboard/google/octopus/variants/bloog/variant.c:
https://review.coreboot.org/c/coreboot/+/38716/2/src/mainboard/google/octopu...
PS2, Line 69: sku_id == SKU_53_BIPSHIP || sku_id == SKU_54_BIPSHIP
This check seems to be growing.
If more SKUs are going to use Blooguard VBT, then it is probably better to invert the check i.e. if Bloog SKUs then return vbt.bin. Return vbt-blooguard.bin for other SKUs.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38716
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I61f12d4ddea17a05255751fde2a5ce822dd2e782
Gerrit-Change-Number: 38716
Gerrit-PatchSet: 2
Gerrit-Owner: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 05 Feb 2020 16:34:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment