Attention is currently required from: Angel Pons. Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47892 )
Change subject: mb/system76/oryp5: Add System76 Oryx Pro 5 ......................................................................
Patch Set 6:
(4 comments)
File Documentation/mainboard/system76/oryp5.md:
https://review.coreboot.org/c/coreboot/+/47892/comment/a396b16b_15906f1d PS5, Line 15: 2666 MHz
These are from the marketing material, which it seems most vendors use MHz instead of MT/s. […]
Done
File src/mainboard/system76/oryp5/Kconfig:
https://review.coreboot.org/c/coreboot/+/47892/comment/106b0949_f0f3ef77 PS5, Line 12: HAVE_SMI_HANDLER
Selected by the SOC, will remove.
Done
File src/mainboard/system76/oryp5/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/47892/comment/03fb68c1_bdaaca64 PS5, Line 41: WARNING: must then be mapped from FSP value to PCH value
Potentially. But I'm more inclined to just remove the comments like this. […]
Done
File src/mainboard/system76/oryp5/gpio.c:
https://review.coreboot.org/c/coreboot/+/47892/comment/ef3074f5_33884a0e PS5, Line 98: PAD_NC(GPP_C20, UP_20K), // UART2_RXD (test point) : PAD_NC(GPP_C21, UP_20K), // UART2_TXD (test point)
Yes please, for the sake of completeness
Done